fix: revert openresty ngx.req_body() stream process hardcode limitation#12658
Merged
Conversation
oowl
marked this pull request as ready for review
February 28, 2024 08:52
This was referenced Feb 28, 2024
vm-001
reviewed
Feb 28, 2024
vm-001
reviewed
Feb 28, 2024
vm-001
approved these changes
Feb 28, 2024
chronolaw
reviewed
Feb 29, 2024
chronolaw
approved these changes
Feb 29, 2024
dndx
approved these changes
Feb 29, 2024
oowl
added
the
cherry-pick kong-ee
Collaborator
|
Successfully created cherry-pick PR for |
github-actions Bot
pushed a commit
that referenced
this pull request
Feb 29, 2024
…oding limitation (#12658) Cherry picked from openresty/lua-nginx-module#2286. It was acknowledged by OpenResty as a mistaken breaking change, and we should revert it. FTI-5766 FTI-5795 (cherry picked from commit 55358df)
3 tasks
Collaborator
|
'git push --set-upstream upstream cherry-pick-12658-to-master-to-upstream' failed with exit code 1 |
Collaborator
|
Successfully created backport PR for |
windmgc
pushed a commit
that referenced
this pull request
Mar 1, 2024
…oding limitation (#12658) Cherry picked from openresty/lua-nginx-module#2286. It was acknowledged by OpenResty as a mistaken breaking change, and we should revert it. FTI-5766 FTI-5795 (cherry picked from commit 55358df)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Revert the hard-coded limitation of the ngx.read_body() API in OpenResty upstreams' new versions when downstream connections are in HTTP/2 and HTTP/3 stream modes.
upstream: openresty/lua-nginx-module#2286
Checklist
changelog/unreleased/kongorskip-changeloglabel added on PR if changelog is unnecessary. README.mdIssue reference
FTI-5766 FTI-5795