Skip to content

Add Gateway 3.14 conversion tooling#1890

Merged
Prashansa-K merged 3 commits intomainfrom
config-upgrade-314
Feb 27, 2026
Merged

Add Gateway 3.14 conversion tooling#1890
Prashansa-K merged 3 commits intomainfrom
config-upgrade-314

Conversation

@mheap
Copy link
Member

@mheap mheap commented Feb 12, 2026

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 12, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 66.36364% with 37 lines in your changes missing coverage. Please review.
✅ Project coverage is 33.65%. Comparing base (9fce824) to head (23b6b51).

Files with missing lines Patch % Lines
convert/plugin_updates_314.go 65.11% 11 Missing and 4 partials ⚠️
convert/convert.go 61.53% 6 Missing and 4 partials ⚠️
cmd/file_convert.go 0.00% 4 Missing ⚠️
convert/route_updates_314.go 80.95% 2 Missing and 2 partials ⚠️
convert/service_updates_314.go 75.00% 2 Missing and 2 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1890      +/-   ##
==========================================
+ Coverage   33.11%   33.65%   +0.54%     
==========================================
  Files          73       76       +3     
  Lines        6572     6682     +110     
==========================================
+ Hits         2176     2249      +73     
- Misses       4228     4253      +25     
- Partials      168      180      +12

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mheap mheap requested a review from Prashansa-K February 18, 2026 12:29
Prashansa-K
Prashansa-K reviewed Feb 26, 2026
View reviewed changes
convert/testdata/11/output-expected.yaml
account_email: [email protected]
ssl_verify: false
name: acme
protocols:
Copy link
Contributor

@Prashansa-K Prashansa-K Feb 26, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This top level route had no protocols defined. As per the ruleset, this should have got https only, right?

I interpreted it wrong. If no protocols are set, we are explicitly setting them to [http, https] (old defaults). I believe this is done so that nothing breaks in the config.

@Prashansa-K
Copy link
Contributor

Prashansa-K commented Feb 26, 2026

Changes are good.
Konnect tests are failing due to change in defaults in 3.14.
Linting module go-sec is mistakenly marking test data as credentials/secrets. I will fix that in a diff PR and then update this one.

@Prashansa-K Prashansa-K mentioned this pull request Feb 26, 2026
Merged
@Prashansa-K
Copy link
Contributor

Prashansa-K commented Feb 26, 2026

#1895
This PR fixes the tests.

@Prashansa-K Prashansa-K merged commit 7ee7461 into main Feb 27, 2026
40 of 45 checks passed
@Prashansa-K Prashansa-K deleted the config-upgrade-314 branch February 27, 2026 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Prashansa-K Prashansa-K Prashansa-K approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mheap @codecov-commenter @Prashansa-K