fix: json summary output and dropped events addition#1841
Merged
Prashansa-K merged 3 commits intomainfrom Feb 17, 2026
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1841 +/- ##
==========================================
+ Coverage 32.74% 33.11% +0.36%
==========================================
Files 73 73
Lines 6566 6572 +6
==========================================
+ Hits 2150 2176 +26
+ Misses 4252 4228 -24
- Partials 164 168 +4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Prashansa-K
force-pushed
the
fix/json-output
branch
from
f04af5b to
46eae72
Compare
shivaygupta-dotcom
approved these changes
Feb 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the way we were handling json output earlier, it showed false summary output if an
upstream error occurred. The user didn't see what operations were performed on the gateway
as the summary showed 0 for all ops.
This is fixed in this PR. Now, json output is similar to yaml output in terms of summary printing.
Further, we have added the new fields added in GDR for dropped operations.
Kong/go-database-reconciler#362
Added a unit test for json output. At the moment, we can't simulate error in
performDiff that can fill Dropped operations.
One way was to set a negative parallelism to trigger this error.
However, there's a bug in go-database-reconciler where Run() returns early on
parallelism < 1 without closing channels, causing Solve() to hang when
it tries to range over sc.eventChan.
Captured the bug here: Kong/go-database-reconciler#375
Not prioritising this or the error test yet as this is not a burning issue.
For #1854