fix: Request transformer diff for array#1819
Merged
harshadixit12 merged 5 commits intomainfrom Nov 25, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1819 +/- ##
=======================================
Coverage 32.79% 32.79%
=======================================
Files 73 73
Lines 6556 6556
=======================================
Hits 2150 2150
Misses 4242 4242
Partials 164 164 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
harshadixit12
force-pushed
the
fix/request-transformer-array-diff
branch
from
ed1bf63 to
b3ce352
Compare
5 tasks
harshadixit12
commented
Nov 19, 2025
| _format_version: "3.0" | ||
| plugins: | ||
| - name: request-transformer | ||
| protocols: |
Contributor
Author
There was a problem hiding this comment.
In gateway 2.8, the plugin schema does not contain protocols - which leads to a false diff. I've chosen to add this to keep the test implement small - otherwise we would need separate tests, and yaml files for 2.8
Contributor
|
LGTM. Once go.mod is updated, we can merge. |
harshadixit12
force-pushed
the
fix/request-transformer-array-diff
branch
from
b6a9494 to
a64e74f
Compare
harshadixit12
force-pushed
the
fix/request-transformer-array-diff
branch
from
a64e74f to
ef57b23
Compare
Contributor
Author
|
@Prashansa-K GDR is bumped, also added a couple of changes to konnect tests to fix CI - ef57b23 |
Prashansa-K
approved these changes
Nov 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
We are skipping sorting fields of type
arrayin plugin config based on plugin schema.PR on GDR: Kong/go-database-reconciler#358
Fixes: #1741
Previous conversations:
https://kongstrong.slack.com/archives/C03CTMSHP6C/p1757571761637079?thread_ts=1757571602.514959&cid=C03CTMSHP6C
https://kongstrong.slack.com/archives/C07AQH7SAF8/p1763534009205859
Konnect tests are failing for a different reason - PR to fix