Skip to content

chore: bumped golang to v1.25.3#1816

Merged
Prashansa-K merged 4 commits intomainfrom
chore/go-bump
Nov 13, 2025
Merged

chore: bumped golang to v1.25.3#1816
Prashansa-K merged 4 commits intomainfrom
chore/go-bump

Conversation

@Prashansa-K
Copy link
Contributor

@Prashansa-K Prashansa-K commented Nov 12, 2025

  • Bumping golang to v1.25.3 to account for FTI
  • This bump requires us to bump golangci-lint to a supported version.
  • golangci-lint v8 only supports v2 lint-config. Config is migrated via golangci-lint migrate command based on the guide.
  • Linted code.

@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2025

Codecov Report

❌ Patch coverage is 57.50000% with 34 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.79%. Comparing base (19d969e) to head (b6c6f7e).

Files with missing lines Patch % Lines
docs/generate-docs.go 0.00% 11 Missing ⚠️
kong2kic/route.go 58.82% 6 Missing and 1 partial ⚠️
kong2kic/upstream.go 50.00% 2 Missing and 2 partials ⚠️
cmd/common.go 0.00% 3 Missing ⚠️
cmd/file_kong2kic.go 0.00% 3 Missing ⚠️
kong2kic/consumer_credentials.go 71.42% 2 Missing ⚠️
kong2kic/builder.go 80.00% 1 Missing ⚠️
kong2kic/service.go 66.66% 0 Missing and 1 partial ⚠️
kong2kic/types.go 66.66% 1 Missing ⚠️
validate/validate.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1816      +/-   ##
==========================================
+ Coverage   32.76%   32.79%   +0.03%     
==========================================
  Files          73       73              
  Lines        6556     6556              
==========================================
+ Hits         2148     2150       +2     
  Misses       4242     4242              
+ Partials      166      164       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

with:
go-version-file: go.mod
- uses: golangci/golangci-lint-action@ec5d18412c0aeab7936cb16880d708ba2a64e1ae # v6.2.0
- uses: golangci/golangci-lint-action@4afd733a84b1f43292c63897423277bb7f4313a9 # v8.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's update this in the validate-action-shas.sh script as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is that script? This action seems to be referred here only.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah my bad, it's not there in repo. It was a custom script on my local. PR lgtm.

@Prashansa-K Prashansa-K merged commit 83de7f6 into main Nov 13, 2025
38 checks passed
@Prashansa-K Prashansa-K deleted the chore/go-bump branch November 13, 2025 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants