fix: consumerGroupConsumer pulling modified to account for presence of consumers in targetContent#1813
Merged
Prashansa-K merged 4 commits intomainfrom Nov 12, 2025
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1813 +/- ##
==========================================
- Coverage 32.83% 32.76% -0.08%
==========================================
Files 73 73
Lines 6550 6556 +6
==========================================
- Hits 2151 2148 -3
- Misses 4234 4242 +8
- Partials 165 166 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
cmd/common.go
Outdated
| if groupExists { | ||
| consumerGroupObject.Consumers = append(consumerGroupObject.Consumers, consumer) | ||
| } | ||
| // else { |
Contributor
There was a problem hiding this comment.
This branch is not required?
Contributor
Author
There was a problem hiding this comment.
Stray code 😮💨 . I will remove it. Leave a comment when the initial review is completed.
harshadixit12
approved these changes
Nov 11, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were checking for group memberships while pulling consumer-groups via default_lookup_tags.
Checking for these memberships is important when consumers are a part of the targetContent. That way, we
can ensure that any removals or updates in groups for consumers can go through.
However, if the targetContent under process doesn't have any consumers, we can skip the check and add the
necessary consumerGroupConsumers. This also ensures that we aren't deleting any consumerGroupConsumers
by accident, in case a group match fails.
FTI: https://konghq.atlassian.net/browse/FTI-6966?focusedCommentId=182193&sourceType=mention