Skip to content

tests: test fix and add for shorthand_fields handling in gateway dump#1810

Merged
Prashansa-K merged 4 commits intomainfrom
fix/shorthand-field-defaults-skip
Nov 6, 2025
Merged

tests: test fix and add for shorthand_fields handling in gateway dump#1810
Prashansa-K merged 4 commits intomainfrom
fix/shorthand-field-defaults-skip

Conversation

@Prashansa-K
Copy link
Contributor

Corresponding GDR PR: Kong/go-database-reconciler#357
For #1808

@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 32.79%. Comparing base (c8b1fcc) to head (170cadb).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1810   +/-   ##
=======================================
  Coverage   32.79%   32.79%           
=======================================
  Files          73       73           
  Lines        6550     6550           
=======================================
  Hits         2148     2148           
  Misses       4236     4236           
  Partials      166      166           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

issuer: http://example-issuer.com
redis:
timeout: 2000
session_redis_cluster_max_redirections: 5
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were shorthand_fields. Hence, with the current change, they would no longer show up.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have an instance in tests where shorthand field was configured with a non-default value?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add one

@Prashansa-K
Copy link
Contributor Author

Prashansa-K commented Nov 6, 2025

Konnect tests are failing due to flakiness. Specific dump --skip-defaults tests are passing.
Could be related to this: https://kongstrong.slack.com/archives/C09QYJ51GUS

Skipped a flaky test for now. This will be updated later; post the dev environment incident is resolved.
The concerned test is passing when checked against a prod environment locally. So, this is just limited to dev.

@Prashansa-K
Copy link
Contributor Author

Konnect tests are failing with 5xx. I will retry once after gdr version update here. Verified the changes on local.

@Prashansa-K Prashansa-K merged commit 44bdaa1 into main Nov 6, 2025
38 checks passed
@Prashansa-K Prashansa-K deleted the fix/shorthand-field-defaults-skip branch November 6, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants