fix: consumer lookups while using default lookup tags for consumer-goups#1749
Merged
Prashansa-K merged 3 commits intomainfrom Sep 17, 2025
Merged
fix: consumer lookups while using default lookup tags for consumer-goups#1749Prashansa-K merged 3 commits intomainfrom
Prashansa-K merged 3 commits intomainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1749 +/- ##
==========================================
- Coverage 32.89% 32.84% -0.06%
==========================================
Files 73 73
Lines 8068 8093 +25
==========================================
+ Hits 2654 2658 +4
- Misses 5248 5270 +22
+ Partials 166 165 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Prashansa-K
force-pushed
the
fix/default-lookup-consumer-groups
branch
from
0d40193 to
4c75590
Compare
Prashansa-K
changed the title
Prashansa-K
requested review from
harshadixit12
and removed request for
harshadixit12
Prashansa-K
commented
Sep 5, 2025
go.mod
Outdated
| github.com/google/go-cmp v0.7.0 | ||
| github.com/kong/go-apiops v0.1.49 | ||
| github.com/kong/go-database-reconciler v1.26.0 | ||
| github.com/kong/go-database-reconciler v1.26.1-0.20250902104042-b53c60cc6db1 |
Contributor
Author
There was a problem hiding this comment.
To be updated post this pr merge: Kong/go-database-reconciler#336
Prashansa-K
force-pushed
the
fix/default-lookup-consumer-groups
branch
from
9b2c3c2 to
30a7894
Compare
harshadixit12
approved these changes
Sep 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Syncing and diffing with default_lookup_tags
for consumer-groups was errorneous. While
dumping config, we would dump all consumers
in case of default-lookup tags. Thus, in case of
serial syncing of consumers, previous consumers
would end up getting deleted.
This fix ensures that no unexpected deletions occur
while using consumer-group lookups.
Issue is described in detail in
the doc and FTI below: