wallet::CreateCoinStake set missing pindeFrom in stakeInput.

furszy · furszy · commit af1bf37a3543 · 2020-10-05T11:14:25.000-03:00
Before was loaded in GetIndexFrom and such functionality was removed.
diff --git a/src/wallet/wallet.cpp b/src/wallet/wallet.cpp
@@ -2757,6 +2757,7 @@ bool CWallet::CreateCoinStake(
     for (const auto& out : *availableCoins) {
         CPivStake stakeInput;
         stakeInput.SetPrevout(out.tx->vout[out.i], COutPoint(out.tx->GetHash(), out.i));
+        stakeInput.SetIndexFrom(out.pindex);
 
         //new block came in, move on
         if (WITH_LOCK(cs_main, return chainActive.Height()) != pindexPrev->nHeight) return false;
@@ -4043,7 +4044,7 @@ void CMerkleTx::SetMerkleBranch(const CBlockIndex* pindex, int posInBlock)
 
 int CMerkleTx::GetDepthInMainChain(bool enableIX) const
 {
-    const CBlockIndex* pindexRet;
+    const CBlockIndex* pindexRet = nullptr;
     return GetDepthInMainChain(pindexRet, enableIX);
 }
 

Original file line number	Diff line number	Diff line change
`@@ -2757,6 +2757,7 @@ bool CWallet::CreateCoinStake(`
`2757`	`2757`	`for (const auto& out : *availableCoins) {`
`2758`	`2758`	`CPivStake stakeInput;`
`2759`	`2759`	`stakeInput.SetPrevout(out.tx->vout[out.i], COutPoint(out.tx->GetHash(), out.i));`
	`2760`	`+ stakeInput.SetIndexFrom(out.pindex);`
`2760`	`2761`
`2761`	`2762`	`//new block came in, move on`
`2762`	`2763`	`if (WITH_LOCK(cs_main, return chainActive.Height()) != pindexPrev->nHeight) return false;`
`@@ -4043,7 +4044,7 @@ void CMerkleTx::SetMerkleBranch(const CBlockIndex* pindex, int posInBlock)`
`4043`	`4044`
`4044`	`4045`	`int CMerkleTx::GetDepthInMainChain(bool enableIX) const`
`4045`	`4046`	`{`
`4046`		`- const CBlockIndex* pindexRet;`
	`4047`	`+ const CBlockIndex* pindexRet = nullptr;`
`4047`	`4048`	`return GetDepthInMainChain(pindexRet, enableIX);`
`4048`	`4049`	`}`
`4049`	`4050`