[Budget] Make sorting of finalized budgets deterministic

Mrs-X · Mrs-X · commit 93e637f216c7 · 2018-05-11T22:36:54.000+02:00
diff --git a/src/masternode-budget.cpp b/src/masternode-budget.cpp
@@ -844,10 +844,13 @@ std::vector<CBudgetProposal*> CBudgetManager::GetBudget()
     return vBudgetProposalsRet;
 }
 
+// Sort by votes, if there's a tie sort by their feeHash TX
 struct sortFinalizedBudgetsByVotes {
     bool operator()(const std::pair<CFinalizedBudget*, int>& left, const std::pair<CFinalizedBudget*, int>& right)
     {
-        return left.second > right.second;
+        if (left.second != right.second)
+            return left.second > right.second;
+        return (left.first->nFeeTXHash > right.first->nFeeTXHash);
     }
 };
 

Original file line number	Diff line number	Diff line change
`@@ -844,10 +844,13 @@ std::vector<CBudgetProposal*> CBudgetManager::GetBudget()`
`844`	`844`	`return vBudgetProposalsRet;`
`845`	`845`	`}`
`846`	`846`
	`847`	`+// Sort by votes, if there's a tie sort by their feeHash TX`
`847`	`848`	`struct sortFinalizedBudgetsByVotes {`
`848`	`849`	`bool operator()(const std::pair<CFinalizedBudget, int>& left, const std::pair<CFinalizedBudget, int>& right)`
`849`	`850`	`{`
`850`		`- return left.second > right.second;`
	`851`	`+ if (left.second != right.second)`
	`852`	`+ return left.second > right.second;`
	`853`	`+ return (left.first->nFeeTXHash > right.first->nFeeTXHash);`
`851`	`854`	`}`
`852`	`855`	`};`
`853`	`856`