Php7-3#3
Merged
Jarrich merged 4 commits intoKo-fi:masterfrom Mar 6, 2020
marklchaves:php7
Merged
Conversation
|
Any news about this fix? |
Contributor
Author
|
Hi @max23468, Still waiting for a review. I hope we'll get one soon! Thanks for asking. |
Contributor
|
Sorry for the silence. You can expect some movement on this soon 👍 |
|
Hope to see some updated to the plugin soon! |
Contributor
|
Thank you for the contribution @marklchaves |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 7.3
Replaced one call to deprecated
create_function. Deprecated in 7.2.jscolor
Installed latest jscolor (version 2.0.5). http://jscolor.com/release/latest.zip
Typos
Testing
PHP 7.3.2 and WordPress 5.3. Safari 13.0.4, Firefox 71, and Chrome 78 on MacOS.
wp_debugon. Observed deprecated warning. No other warnings.Notes
Only question was if unchecking the Hyperlink setting is supposed to disable linking for the widget? Oh, it looks like there's support for a custom shortcode? Any documentation on that? I can test that too.
Attached before/after logs.
ko-fi-button-php-compatibility-report-11dec2019.txt
ko-fi-button-php-compatibility-report-12dec2019.txt
Note: Sorry about the FUNDING.yml update. Didn't realised this file would be included 😬 Feel free to delete?