Skip to content

Comments

Only have the qtfred button appear when qtfred is available#316

Merged
JohnAFernandez merged 2 commits intoKnossosNET:mainfrom
JohnAFernandez:Disable-QTFred-Button-sometimes
Mar 25, 2025
Merged

Only have the qtfred button appear when qtfred is available#316
JohnAFernandez merged 2 commits intoKnossosNET:mainfrom
JohnAFernandez:Disable-QTFred-Button-sometimes

Conversation

@JohnAFernandez
Copy link
Contributor

Disallow the qtfred and qtfred debug buttons when those builds are not available. Tested using 22.2 and 24.2]

Disallow the qtfred and qtfred debug buttons when those builds are not available.
@JohnAFernandez JohnAFernandez added the ui User interface related label Mar 20, 2025
@JohnAFernandez JohnAFernandez added this to the 1.3.1 milestone Mar 20, 2025
@JohnAFernandez JohnAFernandez self-assigned this Mar 20, 2025
@wookieejedi
Copy link
Contributor

wookieejedi commented Mar 20, 2025

Oh cool! Though only caveat is that in my tests the QTFRED button still appears while in TC mode.

Looks like QtFRED visibility check is needed also in CustomHomeView.axaml, though that IsVisible="{Binding IsQtFredAvailable}" binding will not work in that file since it will not recognize it as it has a different name space.

I'd also be happy to test any updates!

Copy link
Contributor

@wookieejedi wookieejedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works in my tests, thanks again for taking this on!

@JohnAFernandez JohnAFernandez merged commit 2e066e3 into KnossosNET:main Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui User interface related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants