when deleting mods, delete them to the Recycle Bin#314
Merged
JohnAFernandez merged 3 commits intoKnossosNET:mainfrom Mar 19, 2025
Merged
when deleting mods, delete them to the Recycle Bin#314JohnAFernandez merged 3 commits intoKnossosNET:mainfrom
JohnAFernandez merged 3 commits intoKnossosNET:mainfrom
Conversation
It's possible to delete files to the Recycle Bin, as shown here: https://www.csharp.com/blogs/extension-methods-for-delete-files-and-folders-to-recycle-bin Documentation here: https://learn.microsoft.com/en-us/dotnet/api/microsoft.visualbasic.fileio.filesystem.deletedirectory?view=net-9.0 Motivated by the sad story of 'In the Beginning' posted here: https://www.hard-light.net/forums/index.php?topic=98100.msg1921007#msg1921007
Contributor
|
This needs cross-platform testing, but I'm on board with the changes. |
Contributor
Author
|
According to ShivanSpS, it produces an error on Linux, but there should be a straightforward way around that. I need a little bit more information and then I'll try a fix. I'll put it in draft in the meantime. |
Contributor
Author
|
With the latest change, ShivanSpS reports a successful fall back to regular deletion. |
Shivansps
approved these changes
Mar 13, 2025
Member
Shivansps
left a comment
Shivansps
left a comment
There was a problem hiding this comment.
Works correctly. it recycles on windows and it is deleted permantly on Linux as a fallback
Well done.
JohnAFernandez
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's possible to delete files to the Recycle Bin, as shown here: https://www.csharp.com/blogs/extension-methods-for-delete-files-and-folders-to-recycle-bin
Documentation here:
https://learn.microsoft.com/en-us/dotnet/api/microsoft.visualbasic.fileio.filesystem.deletedirectory?view=net-9.0
Motivated by the sad story of 'In the Beginning' posted here: https://www.hard-light.net/forums/index.php?topic=98100.msg1921007#msg1921007