Merged
Conversation
This should finally make the debug tab look a lot less shabby
JohnAFernandez
added
cleanup
wookieejedi
reviewed
Mar 8, 2025
Knossos.NET/Views/DebugView.axaml
Outdated
| <Button Margin="5" Classes="Settings" Command="{Binding UploadKnossosConsole}">Upload KnossosNET Console</Button> | ||
| <Button Margin="5" Classes="Settings" Command="{Binding OpenLog}">View KnossosNET Logfile</Button> | ||
| <Button Margin="5" Classes="Settings" Command="{Binding OpenSettings}">View KnossosNET Settings File</Button> | ||
| <Button Margin="5" Width="175" Classes="Primary" Command="{Binding UploadKnossosConsole}">Upload Knossos Log</Button> |
Contributor
There was a problem hiding this comment.
Current protocol has been to use KnossosNET as all public facing mentions of Knossos, so my only suggestion is the use that in these cases :)
Contributor
Author
There was a problem hiding this comment.
I will implement this, but it's looking like it makes my current layout too wonky. I am going to rearrange a couple things.
Includes change to KnossosNET
Shivansps
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should finally make the debug tab look a lot less shabby. Make the buttons uniform size, add wordwrap and margin to the console, Add a small descriptor to it, and make upload knossos log
a primary button.