Warn Users If Library Folder is Missing#310
Merged
JohnAFernandez merged 2 commits intoKnossosNET:mainfrom Mar 25, 2025
Merged
Conversation
Contributor
|
Tested on Mac and Linux and it appeared to work as expected. I tried renaming the library directory to trigger the missing warning as well as changing the permissions to make it unusable. And the Linux test was a fresh install. However I did notice two issues with the warning message itself: the second "knossos" should be capitalized, and the word "select" is spelled wrong (slect) |
Contributor
Author
|
Thank you! Good to know my biggest mistakes are typos |
Contributor
|
Guess piggy backing on the text request, all other public facing text says |
Shivansps
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Give the user a basic warning if their library folder has moved.
Not fully tested on all platforms, so in draft status. Could also use a test on a fresh install.