Allow to reset or ignore ingame options from mod settings window#308
Merged
Shivansps merged 3 commits intoKnossosNET:mainfrom Feb 22, 2025
Merged
Conversation
wookieejedi
reviewed
Feb 20, 2025
| </WrapPanel> | ||
| <!--Mod Engine Settings--> | ||
| <Label Margin="0,20,0,0" FontWeight="Black" FontSize="20">ENGINE SETTINGS</Label> | ||
| <CheckBox IsChecked="{Binding NoIngameOptions}" Margin="5" ToolTip.Tip="By disabling ingame options, launcher engine settings will be used instead. Only valid if the mod uses a FSO engine build equal or higher than version 24.2.0"> |
Contributor
There was a problem hiding this comment.
Nice, just small suggestion: to make consistent with other public facing uses of the word it might be best to use in-game. Also do we want this tooltip sentence and the others to end in a period. Right now one does but others do not. That's of course very minor but just something I noticed :D
wookieejedi
reviewed
Feb 20, 2025
| Disable ingame options | ||
| </CheckBox> | ||
| <WrapPanel IsVisible="{Binding !NoIngameOptions}"> | ||
| <Label VerticalAlignment="Center" Margin="5" FontWeight="Bold" IsVisible="{Binding IngameOptionsFileExist}" Foreground="Yellow" ToolTip.Tip="This file is used to save ingame FSO engine settings not managed by Knossos.NET">Ingame options file detected</Label> |
Contributor
There was a problem hiding this comment.
same note as above, suggestion to switch ingame to in-game
wookieejedi
reviewed
Feb 20, 2025
| <WrapPanel IsVisible="{Binding !NoIngameOptions}"> | ||
| <Label VerticalAlignment="Center" Margin="5" FontWeight="Bold" IsVisible="{Binding IngameOptionsFileExist}" Foreground="Yellow" ToolTip.Tip="This file is used to save ingame FSO engine settings not managed by Knossos.NET">Ingame options file detected</Label> | ||
| <Button Command="{Binding ViewIngameOptions}" IsVisible="{Binding IngameOptionsFileExist}" Margin="5" Classes="Option" ToolTip.Tip="Open the file in a text editor.">View</Button> | ||
| <Button Command="{Binding DeleteIngameOptions}" IsVisible="{Binding IngameOptionsFileExist}" Margin="5" Classes="Cancel" ToolTip.Tip="By deleting the FSO ingame options file all values will be reseted back to default the next time you launch this mod">Delete</Button> |
Contributor
There was a problem hiding this comment.
same note as above, suggestion to switch ingame to in-game
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows to have a toggle for "no ingame options" in mod settings.
Also allows to delete or view the file in question if it exist.
i really dont want to do much more otherwise the whole point of ingame options becomes irrelevant.