Hide more advanced video options#302
Merged
wookieejedi merged 4 commits intoKnossosNET:mainfrom Feb 10, 2025
Merged
Conversation
There have been new players/testers that have disabled `Vsync` and `120 FPS Limit` without fully realizing the downstream side effects and then ran into various issues. These are typically somewhat advanced options for graphics, so after talking it over this PR removes them by commenting out the UI fields from the global graphics options.
Shivansps
approved these changes
Feb 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There have been new players/testers that have disabled
Vsyncand120 FPS Limitwithout fully realizing the downstream side effects and then ran into various issues. These are typically somewhat advanced options for graphics, so after talking it over this PR removes them by commenting out the UI fields from the global graphics options.