Merged
Conversation
wookieejedi
approved these changes
Feb 6, 2025
Contributor
wookieejedi
left a comment
wookieejedi
left a comment
There was a problem hiding this comment.
Works in my tests, and might be good to have this merged for when taylor tests master?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My initial tests seems fine, but everything needs to be checked.
Notes:
-Microsoft.Extensions.Http is updated to version 8.0.1, NET6 support was dropped since version 9.0.0
-AnimatedImage.Avalonia is not updated to version 2.0.0 because some change was done on bindings and it stops working on some cases in our implementation. We will stay on 1.0.7 for now.