Sort and filtering rework, and add basic mod tag support#275
Merged
Shivansps merged 13 commits intoKnossosNET:mainfrom Jan 29, 2025
Merged
Sort and filtering rework, and add basic mod tag support#275Shivansps merged 13 commits intoKnossosNET:mainfrom
Shivansps merged 13 commits intoKnossosNET:mainfrom
Conversation
Shivansps
added
enhancement
Contributor
|
Tests all work really well, and the mod list loading is way faster which is great to finally have fixed! Only small thing I would mention is that it would look a bit cleaner to have the filter names capitalized :) |
wookieejedi
approved these changes
Jan 26, 2025
Contributor
wookieejedi
left a comment
wookieejedi
left a comment
There was a problem hiding this comment.
Works well and tests work as expected, awesome stuff!
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sort and filtering was almost completely re-done.
This should be a little bit faster.
Also added mod tag in some basic form. Hardcoded and runtime generated.