Make Settings Tab always consistent#273
Merged
wookieejedi merged 1 commit intoKnossosNET:mainfrom Jan 25, 2025
Merged
Conversation
Following user testing, in instructions throughout FSO websites and discussions, the `Settings` tab in Knossos is commonly referred to. The standalone TC mode changes that name to `Options` which was b/c the name `Settings` was already used in the mod `Settings` button on the Home Screen. That button is more of an `Advanced` settings especially for TC mode, so this PR proposes changing keeping the global `Settings` tab as `Settings` so that users will always understand instructions from community members and the QuickStart Guide regarding which tab controls global settings. This PR also proposes changing the default name of the `Settings` button on the TC mode home screen to `Advanced` by default, but of course mods can set this text to whatever they want since TC mode exposes that option. Would be happy to dicuss if useful, too, thanks!
wookieejedi
added
documentation
Shivansps
approved these changes
Jan 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following user testing, in instructions throughout FSO websites and discussions, the
Settingstab in Knossos is commonly referred to. The standalone TC mode changes that name toOptionswhich was b/c the nameSettingswas already used in the modSettingsbutton on the Home Screen. That button is more of anAdvancedsettings especially for TC mode, so this PR proposes changing keeping the globalSettingstab asSettingsso that users will always understand instructions from community members and the QuickStart Guide regarding which tab controls global settings.This PR also proposes changing the default name of the
Settingsbutton on the TC mode home screen toAdvancedby default, but of course mods can set this text to whatever they want since TC mode exposes that option.Would be happy to discuss if useful, too, thanks!