In devmode do not load dependencies of disabled packages#258
Merged
Shivansps merged 1 commit intoKnossosNET:mainfrom Dec 22, 2024
Merged
In devmode do not load dependencies of disabled packages#258Shivansps merged 1 commit intoKnossosNET:mainfrom
Shivansps merged 1 commit intoKnossosNET:mainfrom
Conversation
wookieejedi
approved these changes
Dec 21, 2024
Member
Author
|
In case anyone wonders, since SCPUI takes longer to load, i reference scpui in a separate package and put everything related on it and i disable it when i dont need to do anything with scpui. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Do not load dependencies of a disabled package in dev mode.
This was accidentaly introduced on #198 because a modflag id of a disabled package in devmode falls into the same condition. So the modflags id referenced by disabled packages must be filtered out if not other enabled package also references it.
I petty much speedran this as i needed it, so more testing is needed in other conditions.