sort mod titles without articles#252
Merged
Shivansps merged 2 commits intoKnossosNET:mainfrom Nov 3, 2024
Merged
Conversation
Member
|
Im not feeling too well today to try it, i think it should work, but the problem here (and i think this may be the reason why you cant compile it) is all those removed "usings" on both files, it certanly cant compile without that. |
Goober5000
force-pushed
the
sort_titles_without_articles
branch
from
5e66041 to
7571dbd
Compare
Contributor
Author
|
Well, that's what the IDE recommended, but I've restored all of the |
Goober5000
force-pushed
the
sort_titles_without_articles
branch
2 times, most recently
from
346a638 to
bb46d7f
Compare
Member
|
I tested now and it seems to work fine in my tests |
Remove 'A', 'An', and 'The' from the beginning of mod titles before sorting them.
Goober5000
force-pushed
the
sort_titles_without_articles
branch
from
bb46d7f to
80baec4
Compare
Contributor
Author
|
Ah, very good. 👍 Taking it out of draft then. |
Shivansps
approved these changes
Nov 1, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove 'A', 'An', and 'The' from the beginning of mod titles before sorting them. Should fix #251.
I can't actually build and test this at the moment, so this PR is in draft until it can be tested.