Skip to content

Comments

Mainview UI Rework#249

Merged
Shivansps merged 11 commits intoKnossosNET:mainfrom
Shivansps:mainview-rework
Oct 31, 2024
Merged

Mainview UI Rework#249
Shivansps merged 11 commits intoKnossosNET:mainfrom
Shivansps:mainview-rework

Conversation

@Shivansps
Copy link
Member

@Shivansps Shivansps commented Oct 18, 2024

3.mp4
  1. New, more modern, navigation menu
  2. Moved debug into its own view
  3. Processed all included images with tinypng
  4. Now some, less important, settings are allowed to be changed in runtime and only be saved to file on app close, this is the case of the sharedmodsort, main menu status and hide builds in the fso picker...
  5. Got rid of the save buton on mod settings window, now saves on window close
  6. Got rid of the save button on globalsettings view, now saves on menu navigation to other page or app close if a value was changed.
  7. Some other, UI related, adjustments here and there
  8. Disabled ini watcher as it is not longer worth it.

@Shivansps Shivansps added the cleanup Cleanup code or other aspect label Oct 18, 2024
@Shivansps Shivansps changed the title Initial ui rework Mainview UI Rework Oct 18, 2024
@Shivansps Shivansps added this to the 1.3 milestone Oct 21, 2024
@Shivansps Shivansps marked this pull request as ready for review October 21, 2024 02:42
@wookieejedi
Copy link
Contributor

wookieejedi commented Oct 21, 2024

Awesome, I can take a look at this today and tomorrow ideally.

Copy link
Contributor

@wookieejedi wookieejedi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems to work for me, and not having to always click Save is such a large improvement!

@Shivansps
Copy link
Member Author

Ok ill merge it, seems fine and i need it as not having it it may cause conflicts with future prs

@Shivansps Shivansps merged commit 9e9f012 into KnossosNET:main Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cleanup Cleanup code or other aspect

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants