Add CRC check during mod upload#221
Merged
Shivansps merged 3 commits intoKnossosNET:mainfrom Aug 26, 2024
Merged
Conversation
-Add a CRC check after compressing a mod pkg, to make sure we arent uploading a corrupted file to nebula. -If the file fails the CRC check up to 5 attempts at recompressing the pkg are done before giving up and cancelling the upload. -Now knossos will use the "max compression parallelism" value to determine how many mod pkgs will be compressed at the same time, previuosly this number was hardcoded to 4. -Lower the default max compression paralelism value from 4 to 2.
wookieejedi
approved these changes
Aug 20, 2024
Contributor
wookieejedi
left a comment
wookieejedi
left a comment
There was a problem hiding this comment.
Looks good to me at least, thanks for turning this around quickly!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is in response to bta mod owners reporting packages being uploaded on a mod update that werent changed, that on futher investigation it was determinated that those packages had a different sha256 hash because they had a single random changed byte, corrupting the file and preventing at least one file from being decompressed correctly.
-Add a CRC check after compressing a mod pkg, to make sure we arent uploading a corrupted file to nebula.
-If the file fails the CRC check up to 5 attempts at recompressing the pkg are done before giving up and cancelling the upload.
-Now knossos will use the "max compression parallelism" value to determine how many mod pkgs will be compressed at the same time, previuosly this number was hardcoded to 4.
-Lower the default max compression paralelism value from 4 to 2.