Adapt loading animations for mod tile tabs#216
Merged
JohnAFernandez merged 3 commits intoKnossosNET:mainfrom Aug 3, 2024
Merged
Adapt loading animations for mod tile tabs#216JohnAFernandez merged 3 commits intoKnossosNET:mainfrom
JohnAFernandez merged 3 commits intoKnossosNET:mainfrom
Conversation
Closed
JohnAFernandez
force-pushed
the
Fix-Sorting-Slowdown
branch
from
f79ef87 to
a88b2ad
Compare
Making sure that the list doesn't briefly appear
JohnAFernandez
force-pushed
the
Fix-Sorting-Slowdown
branch
from
3086d26 to
1d52406
Compare
Shivansps
approved these changes
Aug 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This ameliorates the loading time for mod tiles when populating by showing our knossos animation and a loading label to the mod and nebula tabs when they are sorting, populating or filtering.
There is still approximately 10 seconds before the nebula mod tiles are loaded at least on my machine, so improvements are still possible.