Fix installing compressed fso versions#173
Merged
JohnAFernandez merged 2 commits intoKnossosNET:mainfrom Mar 23, 2024
Merged
Conversation
Contributor
Author
|
grumbles why the heck do I have unrelated stuff in the branch. Please hold |
Mod compression support begins at 23.2 (specifically a 23.1 nightly), but we do have mods on knossos whose default build is 19.0, very different from 23.2. Allowing compression to take place for mods like this does not make sense, unless the user is in Manual mode and knows that they will have to risk a newer build to correctly run the compressed modpack. So, remove the automatic approval if the mod just happens to have a ">=" in the build version.
For clarity
JohnAFernandez
force-pushed
the
Fix-installing-compressed-fso-versions
branch
from
a2c7488 to
59c61ff
Compare
wookieejedi
approved these changes
Mar 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mod compression support begins at 23.2 (specifically a 23.1 nightly), but we do have mods on nebula whose default build is 19.0, very different from 23.2. Allowing compression to take place for mods like this does not make sense, unless the user is in Manual or Always mode and knows that they will have to risk a newer build to correctly run the compressed modpack. So, remove the automatic compression approval if the mod just happens to have a ">=" in the build version.
Tested and this keeps mod compression from automatically happening when the required version is < the supported version.
Fixes #169