Ignore installed builds whiout any valid executables when clicking play#168
Merged
JohnAFernandez merged 2 commits intoKnossosNET:mainfrom Mar 22, 2024
Merged
Conversation
Build selection is done by what is selected by the dependency semantic version, semantic version can give you an invalid build, in the case of Wings of Dawn and linux. 17.0.0 contains linux exec, but 17.0.1 does not, if you manually install 17.0.0 linux build and 17.0.1 windows build is installed, wod will still try to select 17.0.1 what will fail. This pr makes that when clicking play, builds whiout valid executables will not be longer considered for builds selection. Not sure if something can be done during mod install to avoid this same scenario.
Contributor
|
Ok, I'll wait on more testing during mod install before merging. |
JohnAFernandez
approved these changes
Mar 5, 2024
Contributor
|
Mod installation worked fine for me with these changes. I'm going to go ahead and merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Build selection is done by what is selected by the dependency semantic version, semantic version can give you an invalid build, in the case of Wings of Dawn and linux.
17.0.0 contains linux exec, but 17.0.1 does not, if you manually install 17.0.0 linux build and 17.0.1 windows build is installed, wod will still try to select 17.0.1 on linux what will fail. This pr makes that when clicking play, builds whiout valid executables will not be longer considered for builds selection.
Not sure if something can be done during mod install to avoid this same scenario. As things are installing wod on linux will install an empty 17.0.1 because there arent any linux executables in that build.
EDIT: Ok i got a check in during mod install, this will try a maximum of 10 times to get an alternative build that sastifies the dependency if the currently selected one has an incompatible enviroment string.
This is nasty but it is the only thing i could think off since repo_minimal does not allow to properly do this check at the mod install stage.
I checked it with x64 and arm64 linux and it seens to behave as expected, but ill suggest that more testing is done here during mod install.