Set File.Move() on installer update.exe update to override existing file#167
Merged
JohnAFernandez merged 1 commit intoKnossosNET:mainfrom Mar 4, 2024
Merged
Conversation
JohnAFernandez
approved these changes
Mar 4, 2024
Contributor
|
Fixes #166 |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When i was updating the installer version 0.2.0-RC10 to 1.0 i got an error
"you cant create a file that already exists" on "kn_update\update.exe"
I have no idea why that file was there maybe was a leftover with an older version from before we implemented the scripts, as the script should have cleared it. Anyway, overrwritting the file if it exist seems to be the right solution. I dont really know how to test it but it should work.