Fix Knossos Not sorting mods on startup#161
Merged
JohnAFernandez merged 1 commit intoKnossosNET:mainfrom Mar 3, 2024
Merged
Conversation
There were two issues: 1) The mod sorting was happening before the mods were loaded 2) If the saved mod preference was loading by name, it would do nothing since that was the default. This commit sets the initial value to unsorted, sorts when there are actually mods to sort, and only saves a non-unsorted preference.
wookieejedi
approved these changes
Feb 22, 2024
Contributor
wookieejedi
left a comment
wookieejedi
left a comment
There was a problem hiding this comment.
Looks good to me but would be happy to have another set of eyes on this PR, even though it's not that many lines.
notimaginative
added a commit
to notimaginative/Knossos.NET
that referenced
this pull request
Mar 24, 2024
Removes ChangeSort() call from the UIThread as it already does it's business in the UIThread and that appears to freak out on Mac. Issue introduced as part of KnossosNET#161
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were two issues:
The mod sorting was happening before the mods were loaded
If the saved mod preference was loading by name, it would do nothing since that was the default.
This commit sets the initial value to unsorted, sorts when there are actually mods to sort, and only saves a non-unsorted preference.
Fixes #147