Improve New Mod Name During Creation#160
Merged
JohnAFernandez merged 1 commit intoKnossosNET:mainfrom Mar 5, 2024
Merged
Conversation
1) Remove the regex replace for mod names, as there is no restriction in the mod dev details tab. 2) Automatically replace spaces with underscores in the modID 3) Keep track of whether the user has manually set the ModID, and stop automatically setting the ModID from the mod name, if so.
Contributor
|
I don't believe there is any restriction on mod names, just the mod id. Aside from length, nebula itself doesn't limit content on either even though mod id requires a limited character set. Old-knossos does a regex check on the mod id but has no restriction on the name. |
Contributor
Author
|
I'll mark it as ready for review, then. Looks like the regex replace on the mod name was a just a small mistake. |
Shivansps
approved these changes
Mar 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the regex replace for mod names, as there is no restriction in the mod dev details tab.
Automatically replace spaces with underscores in the modID
Keep track of whether the user has manually set the ModID, and stop automatically setting the ModID from the mod name, if so.
Tested.
Fixes #151
In draft until I hear back from ShivanSpS about whether having arbitrary characters in the mod name is supported by Nebula.