Select by default newly added, recommended, mod pkgs during mod install#159
Merged
JohnAFernandez merged 2 commits intoKnossosNET:mainfrom Mar 3, 2024
Merged
Conversation
JohnAFernandez
requested changes
Feb 20, 2024
Contributor
JohnAFernandez
left a comment
JohnAFernandez
left a comment
There was a problem hiding this comment.
Looks good. I just was wondering where the cache code is. Was it already in place?
Member
Author
|
The """cache""" is that local mod list so we only do one api call per mod/ver when we are checking pkgs in this way. Instead of doing like 10 calls if we need to check 10 pkgs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Figureout if a recommended pkg is missing from the previous version we are copying mod pkg selection from because the user unselected the pkg during install or because it is a new mod pkg.
In the case of the later select it by default