Fix AA name overflows and improve tool tips for video options#158
Merged
wookieejedi merged 2 commits intoKnossosNET:mainfrom Feb 22, 2024
Merged
Fix AA name overflows and improve tool tips for video options#158wookieejedi merged 2 commits intoKnossosNET:mainfrom
wookieejedi merged 2 commits intoKnossosNET:mainfrom
Conversation
The new text PR makes two of the longer names in the Video options slightly cutoff. One option is to move the drop downs and check boxes more to the right, but then they would be out of alignment with the rest of the columns from other sections. Another, simpler option might be to just shorten the names, since they are rather long compared to other option names. From my tests, editing the names is the easiest and looks the best. Would be happy to refine as requested of course.
wookieejedi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new text PR makes two of the longer names in the Video options slightly cutoff. One option is to move the drop downs and check boxes more to the right, but then they would be out of alignment with the rest of the columns from other sections. Another, simpler option might be to just shorten the names, since they are rather long compared to other option names. From my tests, editing the names is the easiest and looks the best. Would be happy to refine as requested of course.