Add "raw_path" to TestClient request scope#805
Closed
trimailov wants to merge 2 commits intoKludex:masterfrom
Closed
Add "raw_path" to TestClient request scope#805trimailov wants to merge 2 commits intoKludex:masterfrom
trimailov wants to merge 2 commits intoKludex:masterfrom
Conversation
Contributor
Author
|
Apparently similar PR was made in #635. |
According to ASGI spec [0], connection scope's `raw_path` should be a byte string. [0] https://asgi.readthedocs.io/en/latest/specs/www.html#connection-scope
632512a to
39f448d
Compare
Owner
|
@trimailov Thanks for the PR! 🎉 Sorry for taking so long! Would you mind rebasing it? |
Owner
|
Closed in favor of #1445. Author's commit are preserved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
raw_pathwas missing inTestClientrequest's scope, whereasuvicornhasraw_pathin request's scope. This problem makes it impossible to write tests, when parsing raw path is necessary.I've created this app to prove this:
Launch the app with
uvicorn:Test it with
curl:Test app with
TestClient: