Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR upgrades the minimum Python version requirement from 3.9 to 3.10, enabling the use of newer Python syntax features. The changes modernize the codebase by:
- Adopting PEP 604 union syntax (
X | Yinstead ofUnion[X, Y]) - Moving
Callableimports fromtypingtocollections.abc(PEP 585) - Moving
ParamSpecfromtyping_extensionstotyping(available in Python 3.10+) - Removing Python 3.9-specific conditional imports and version checks
- Removing Python 3.9 wheels and dependencies from lockfile
Reviewed Changes
Copilot reviewed 26 out of 27 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| pyproject.toml | Updates minimum Python version to 3.10 and removes Python 3.9 classifier |
| .github/workflows/main.yml | Removes Python 3.9 from CI test matrix |
| uv.lock | Removes Python 3.9 wheel entries and simplifies dependency resolution markers |
| scripts/test | Removes Python version conditional logic for coverage branching |
| starlette/*.py (multiple) | Modernizes import statements: moves Callable to collections.abc, uses PEP 604 union syntax, removes version checks |
| tests/*.py (multiple) | Modernizes import statements and type annotations consistent with source changes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| for route in routes: | ||
| if isinstance(route, (Mount, Host)): | ||
| if isinstance(route, Mount | Host): |
There was a problem hiding this comment.
The isinstance() function expects a tuple of types, not a union type expression. This should be isinstance(route, (Mount, Host)) to work correctly.
Suggested change
| if isinstance(route, Mount | Host): | |
| if isinstance(route, (Mount, Host)): |
Co-authored-by: Copilot <[email protected]>
nixroxursox
pushed a commit
to nixroxursox/starlette
that referenced
this pull request
Nov 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.