Add client parameter to TestClient#2810
Merged
Kludex merged 12 commits intoKludex:masterfrom Dec 28, 2024
Merged
Conversation
Kludex
requested changes
Dec 26, 2024
Owner
Kludex
left a comment
Kludex
left a comment
There was a problem hiding this comment.
On the "how to test", just see the test_testclient.py, and add an entry with a different client, and check the scope["client"] on the endpoint.
Co-authored-by: Marcelo Trylesinski <[email protected]>
Co-authored-by: Marcelo Trylesinski <[email protected]>
iudeen
changed the title
Kludex
changed the title
client parameter to TestClient
Kludex
reviewed
Dec 26, 2024
Kludex
approved these changes
Dec 26, 2024
Owner
|
Thanks! :) |
WilliamDEdwards
added a commit
to WilliamDEdwards/starlette
that referenced
this pull request
Feb 15, 2025
With Kludex#2810, it is possible to override the client host (i.e. the remote address; see https://www.starlette.io/requests/#client-address). The default value for `TestClient` is `testclient`, but an IP address in most circumstances. The documentation example for overriding the client host uses a full URI, which makes no sense: it's the remote address.
Kludex
pushed a commit
that referenced
this pull request
Feb 16, 2025
…..)` example (#2870) With #2810, it is possible to override the client host (i.e. the remote address; see https://www.starlette.io/requests/#client-address). The default value for `TestClient` is `testclient`, but an IP address in most circumstances. The documentation example for overriding the client host uses a full URI, which makes no sense: it's the remote address.
github-actions bot
pushed a commit
to Kludex/jik
that referenced
this pull request
Feb 17, 2025
…..)` example (#2870) With Kludex/starlette#2810, it is possible to override the client host (i.e. the remote address; see https://www.starlette.io/requests/#client-address). The default value for `TestClient` is `testclient`, but an IP address in most circumstances. The documentation example for overriding the client host uses a full URI, which makes no sense: it's the remote address.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #2295
Added client and port parameter to TestClient