Add authentication args length check#1335
Merged
Kludex merged 5 commits intoKludex:masterfrom Nov 15, 2021
Merged
Conversation
Contributor
Author
|
Did someone get a chance to take a look at this and run the workflows? |
Fix linting
Owner
Yes, but this approach looks more as a workaround to me. I've developed an alternative solution on #1337, which I'm unsure if we should merge it. |
Kludex
requested changes
Nov 15, 2021
Owner
Kludex
left a comment
Kludex
left a comment
There was a problem hiding this comment.
I'm willing to accept it now. Just a linter issue :)
Contributor
Author
|
Yes, I shouldn't try to fix it in the browser with no linting help haha. Thanks! |
Kludex
reviewed
Nov 15, 2021
Contributor
Author
|
Could this fix be released in a new patch version so we can change our dependencies? |
LarsStegman
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for
IndexErrorwhen bothargsandkwargsare specified, resulting in the possibility of trying to access a tuple index that is higher than the tuple size.