Response.delete_cookie accepts cookie options#1228
Merged
Kludex merged 3 commits intoKludex:masterfrom Oct 5, 2021
Merged
Conversation
Owner
|
@BookGin What do you mean by: "Though Thanks for the PR! 🎉 |
Contributor
Author
|
Like this pseudo-code, so we need to instantiate the partial function somewhere..... from functools import partial
def delete_cookie(
self,
key: str,
path: str = "/",
domain: str = None,
secure: bool = False,
httponly: bool = False,
samesite: str = "lax",
) -> None:
if not hasattr(delete_cookie, '_func'):
delete_cookie._func = partial(self.set_cookie, max_age=0, expires=0)
return delete_cookie._func(path, domain, secure, httponly, samesite)Never mind. I don't think it's more readable. Let's just keep things simple. |
Kludex
changed the title
Kludex
approved these changes
Sep 28, 2021
Owner
|
@BookGin Thanks for the PR! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Though
functools.partialcould be used, it needs to be instantiated somewhere. Otherwise it will introduce the overhead of function object every time.Let's just follow werkzeug's implementation.