Don't warn when CRLF is found after last boundary#193
Merged
Conversation
Kludex
changed the title
Owner
Author
|
cc @defnull |
Kludex
added a commit
that referenced
this pull request
Apr 10, 2026
Django's MultiPartParser and Werkzeug's sansio multipart parser both silently accept (and ignore) the optional CRLF + epilogue that RFC 2046 section 5.1.1 allows after the closing boundary. python-multipart was logging "Skipping data after last boundary" instead, and the single- chunk guard added in #193 also missed the case where the trailing CRLF was split across two writes - a trailing `\r` at the end of one chunk would fall through to the warning branch because `i + 1 < length` was false, even though the `\n` arrived in the next chunk. Drop the warning and the split-chunk guard entirely. The epilogue is short-circuited the same way as before (no O(N) scan), just without the spurious log line. Closes #246.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skipping data after the last boundary#192