Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim space off the return type before continuing #1487

Merged
merged 3 commits into from
Feb 22, 2024
Merged

Conversation

paultag
Copy link
Collaborator

@paultag paultag commented Feb 22, 2024

My nightly compiler has a space at the end that the stable compiler doesn't. This will trim space, if it exists, before removing the generic bracket, which will work for both stable and current nightly, future stable.

In the future this may be worth doing a trim on "> " but I don't reckon today is that day.

Copy link

vercel bot commented Feb 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
modeling-app ✅ Ready (Inspect) Visit Preview Feb 22, 2024 8:48pm

My nightly compiler has a space at the end that the stable compiler
doesn't. This will trim space, if it exists, before removing the generic
bracket, which will work for both stable and current nightly, future
stable.

In the future this may be worth doing a trim on "> " but I don't reckon
today is that day.

Signed-off-by: Paul R. Tagliamonte <[email protected]>
@paultag paultag force-pushed the paultag/derive-docs branch from 0176846 to cf75fab Compare February 22, 2024 20:14
@paultag paultag requested a review from jessfraz February 22, 2024 20:27
@paultag
Copy link
Collaborator Author

paultag commented Feb 22, 2024

after landing this i'd love to publish a new version of derive-docs since we use this from crates from inside the repo

@paultag paultag merged commit fccf350 into main Feb 22, 2024
19 checks passed
@paultag paultag deleted the paultag/derive-docs branch February 22, 2024 20:59
@Irev-Dev Irev-Dev mentioned this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant