Skip to content

Matlab bug fix: only add Aout to Fun and Fun_Split for F90#99

Merged
yantosca merged 1 commit intodevfrom
bugfix/matlab
Apr 30, 2024
Merged

Matlab bug fix: only add Aout to Fun and Fun_Split for F90#99
yantosca merged 1 commit intodevfrom
bugfix/matlab

Conversation

@yantosca
Copy link
Copy Markdown
Contributor

@yantosca yantosca commented Apr 30, 2024

This PR implemenmts the fix proposed by @jimmielin in issue #56. Namely, we now declare FUN and FUN_SPLIT with an extra argument (Aout) only for the F90 target language. This should fix the problem described by @jnavarla in #96.

src/gen.c
- Implement the fix proposed by @jimmielin in PR #56.  We now declare
  FUN and FUN_SPLIT with an extra argument (Aout) only for F90.

CHANGELOG.md
- Updated accordingly

Signed-off-by: Bob Yantosca <[email protected]>
@yantosca yantosca added target-languages Related to the language options for KPP-generated code bugfix Fixes a bug or a technical issue labels Apr 30, 2024
@yantosca yantosca self-assigned this Apr 30, 2024
@yantosca yantosca added this to the 3.1.1 milestone Apr 30, 2024
Copy link
Copy Markdown
Member

@jimmielin jimmielin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix Fixes a bug or a technical issue target-languages Related to the language options for KPP-generated code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

$KPP_ROOT_Fun( ) and $KPP_ROOT_Fun_Chem( ) bug still in KPP v3.1.0 for matlab code [BUG/ISSUE] Matlab Fun() issues

2 participants