FIX must be the 2nd argument passed to FUN in int/feuler.f90 (plus doc updates)#61
Merged
FIX must be the 2nd argument passed to FUN in int/feuler.f90 (plus doc updates)#61
Conversation
int/feuler.f90 - In routine FunTemplate, VAR was the 2nd argument passed to FUN, but this should be FIX. This was causing the F variable within FUN to be corrupted, which returned garbage (negative) values. Signed-off-by: Bob Yantosca <[email protected]>
CHANGELOG.md docs/source/getting_started/00_revision_history.rst - Added a note about the bug fix to int/feuler.f90 docs/source/conf.py - Updated version number to 3.0.0-rc.4 Signed-off-by: Bob Yantosca <[email protected]>
yantosca
added
bug
Contributor
|
AFAICS, this is fine. However, maybe Mike also wants to comment, as feuler.f90 is his code? |
Contributor
Author
|
@msl3v, do you have any comments about this? |
Contributor
|
This fix is correct. VAR was included erroneously as an argument to FUN() in feuler.f90. |
Contributor
Author
|
@msl3v @jimmielin @RolfSander: could one of you approve the PR? I can't do it as the author. Then I can merge & release. Thanks! |
Contributor
Author
|
Also note: GitHub allows you to automatically generate release notes based on the comments in the logs from each PR. So it's important that even simple fixes like this go thru a PR. |
jimmielin
approved these changes
Oct 18, 2022
Member
|
Thanks Bob, approved! |
Contributor
|
Wasn't listed as a reviewer. Could I still have approved this? (I looked but didn't see that it was possible) |
Contributor
Author
|
My bad, @msl3v. I should have made you a reviewer. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the corresponding PR to #60. Also, documentation has been updated to denote this will be KPP 3.0.0-rc.4.
Closes #60