Cleanup in auto-reduce code and add CI tests#49
Merged
jimmielin merged 2 commits intoKineticPreProcessor:devfrom Jun 26, 2022
Merged
Cleanup in auto-reduce code and add CI tests#49jimmielin merged 2 commits intoKineticPreProcessor:devfrom
jimmielin merged 2 commits intoKineticPreProcessor:devfrom
Conversation
Contributor
|
looks good |
RolfSander
approved these changes
Jun 26, 2022
Member
Author
|
Thanks @RolfSander I'll go ahead and merge this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR replaces
REAL(kind=dp)inrosenbrock_autoreducewithKPP_REALfor consistency with other integrators.I also added a new driver
general_autoreduceand added a CI testros_autoreducewhich uses the auto-reduction integrator. Interestingly, it runs slower than the regularrosfor some reason. The test is only to make sure the integrator isn't broken in future releases - tests of the AR integrator for science should still use the box model developed by @msl3v here https://github.com/KineticPreProcessor/KPP-AR-boxmodel