Conversation
int/feuler.f90 - Return TOUT (the ending time of the integration) to the calling program via RSTATUS(1). This is necessary in order for box models with the "general" driver to timestep properly. models/carbon.def models/carbon.eqn models/carbon.spc - Describe new KPP test model based on the GEOS-Chem carbon gases mechanism. Necessary for implementing C-I tests with the Forward Euler integrator. ci-tests/F90_feuler/F90_feuler.kpp - KPP file for the F90_feuler C-I test. Uses the carbon mechanism with the Forward Euler (feuler) integrator. .ci-pipelines/ci-common-defs.sh - Add "F90_feuler" to the list of C-I tests to be done docs/source/using_kpp/05_output_from_kpp.rst - Updated the RSTATUS table to denote that the feuler integrator now uses RSTATUS(1) CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
yantosca
added
CI / testing
RolfSander
reviewed
May 6, 2025
Contributor
RolfSander
left a comment
RolfSander
left a comment
There was a problem hiding this comment.
Looks fine to me, but I leave it to Mike to judge. It's his code...
Contributor
|
Looks fine to me too. Easy change. |
RolfSander
approved these changes
May 6, 2025
Contributor
Author
|
Thanks @msl3v and @RolfSander. I'll merge this. I think I will prep a KPP 3.2.1 release since there have been a few fixes since the 3.2.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the companion PR to #135. In this PR we have now done the following:
Modified the
int/feuler.f90("Forward Euler") integrator to returnTexit(the time corresponding to the computed Y value) from to the calling program viaRSTATUS(1). This was a bug that was causing box-model simulations using thegeneraldriver to fail, as the driver was not getting the updated time after each integration call.Added a new model named
carbonbased on the GEOS-Chem carbon gases mechanism. Files describing the model are located atmodels/carbon.def,models/carbon.eqn,models/carbon.spc.Added a new C-I test for the Forward Euler integrator using the carbon model.
Updated ReadTheDocs documentation to denote that the Forward Euler (feuler) integrator now uses
RSTATUS(1).Closes #135
Tagging @RolfSander @jimmielin @msl3v