Allow constants in #INITVALUES to have Fortran double-precision "d" exponents#134
Merged
Allow constants in #INITVALUES to have Fortran double-precision "d" exponents#134
Conversation
docs/source/using_kpp/04_input_for_kpp.rst - Use plain text to for the "2 slashes and a space" comment character, as :code: or :literal: doesn't seem to work. - Added note about using Fortran D exponents. src/scan.l - Added "dD" to the FLOAT and UFLOAT tokens so that it will parse Fortran double-precision exponents properly CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
RolfSander
approved these changes
May 5, 2025
Contributor
RolfSander
left a comment
RolfSander
left a comment
There was a problem hiding this comment.
Looks good. At least we can use 1D0 now. Allowing _sp and _dp as well would be nice but is probably not worth the effort.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the companion PR to issue #133, in which we do the following:
Add
dDto the regular expression for theFLOATandUFLOATtokens insrc/scan.l. This will parse constants in the#INITVALUESsection having Fortran "d" exponents.Added a Note section in the "#INITVALUES" section (in the "Input for KPP" chapter) of ReadTheDocs explaining about Fortran double-precision exponents.