Update int/sdirk.f90 to the same version as was in int/beuler.f90#130
Merged
Update int/sdirk.f90 to the same version as was in int/beuler.f90#130
Conversation
int/sdirk.f90 - Original version has been deleted - int/beuler.f90 is now renamed to int/sdirk.f90 int/beuler.f90 int/beuler.def - Removed docs/source/tech_info/07_numerical_methods.rst - Added documentation instructing user to select #INTEGRATOR sdirk with ICNTRL(3) = 6 for Backwards Euler integration CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
int/sdirk.f90 - Indented & lined up code for readability - Added () to subroutines taking no arguments - Test if the method is Backward Euler (BEL) before multiplying the RoundOff variable by 101 when computing Hstart - Trimmed trailing whitespace Signed-off-by: Bob Yantosca <[email protected]>
yantosca
added
feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the companion PR to #129. In this PR we do the following:
int/beuler.f90toint/sdirk.f90, since the code inint/beuler.f90was a newer version of the SDIRK integrator moduleint/beuler.def#INTEGRATOR sdirkand setICNTRL(3) = 6101*Roundoffin the computation forHstartif the selected integration method is Backward Euler