Conversation
ci-tests/F90_ros_h211b.kpp - New definition file for F90_ros_h211b C-I test w/ saprc99 mechanism .ci-pipelines/ci-common-defs.h - Add F90_ros_h211b to list of the C-I tests int/rosenbrock_h211b_qssa.f90 - Bug fix: "mcm_Function" -> "KPP_ROOT_Function". Removed hardwiring. CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
.ci-pipelines/ci-common-defs.sh - Add new variable MCM_1 and and MCM_2 variable for MCM C-I tests - Now pass the name of the mechanism to functions clean_ci_test_folder and run_ci_test. Also cat the mixrat.dat from the MCM tests to stdout .ci-pipelines/ci-cleanup-script.sh - Pass the name of the KPP mechanism to clean_ci_test_folder .ci-pipelines/ci-testing-script.sh - Pass the name of the KPP mechanism to run_ci_test ci-tests/F90_mcm - Renamed from "mcm". Now link to appropriate KPP files in the ../../examples/mcm folder. ci-tests/F90_mcm_h211b - New C-I test folder. Link to appropriate KPP files in the ../../examples/mcm_h211b folder examples/mcm_h211b - New example folder, based on mcm examples/mcm/run_example.csh examples/mcm_h211b/run_example.csh - Scripts to run the examples (for csh/tcsh) examples/mcm/run_example.sh examples/mcm_h211b/run_example.sh - Scripts to run the examples (for bash) examples/mcm/README.md examples/mcm_h211b/README.md - Updated w/ info about the run_example* scripts CHANGELOG.md - Updated accordingly Signed-off-by: Bob Yantosca <[email protected]>
yantosca
added
feature
|
Note that a manuscript about the H211b integrator is currently under It is possible that there will be some changes to I'm at a meeting this week but should have more time next week to look |
|
That's fine to wait. I just wanted to see if we could wrap up the loose ends eventually and issue a KPP 3.2.0 release. |
|
OK, let's wait until the H211b paper is published. It's fine if the new |
|
Thanks @RolfSander. I'll change the milestone to 3.3.0 for this. I thought we could release 3.2.0 soon just to tie up some of the loose ends into a version. |
RolfSander
left a comment
RolfSander
left a comment
There was a problem hiding this comment.
The paper about the Rosenbrock solver with step size control has finally
been published. I've updated the KPP documentation, and I think we're
ready to merge now.
|
thanks @RolfSander. I'll start merging and we can also release KPP 3.3.0. |
.ci-pipelines/ci-common-defs.sh - Alphabetize the F90 tests, move F90_feuler to the top docs/source/getting-started/00_revision_history.rst - Added sections for KPP 3.2.1 and 3.3.0 docs/source/tech_info/06_info_for_kpp_developers.rst - Convert the list of C-I tests to a list-table - Add info about F90_ros_h211b, F90_mcm_h211b tests - Remove mcm, that is now done with F90_mcm docs/source/using_kpp/04_input_for_rst.kpp - Extend underline for ICNTRL(8) section Signed-off-by: Bob Yantosca <[email protected]>
|
Thanks, @yantosca ! |
2 participants
This is the companion PR to #105 which introduces the Rosenbrock H211b solver. Please see the discussion in #105 for details.
I am planning to merge this into dev so that we can include it in the KPP 3.2.0 release.