Update function prototypes to avoid compiler warnings with GCC 13#103
Merged
Update function prototypes to avoid compiler warnings with GCC 13#103
Conversation
src/code.h - Add "char* rootFileName" as the argument to Use_C, Use_F, Use_F90, and Use_MATLAB function prototypes src/code_c.c - Add "char* rootFileName" as the argument to Use_C src/code_f77.c - Add "char* rootFileName" as the argument to Use_F src/code_f90.c - Add "char *rootFileName" as the argument to Use_F90 src/code_matlab.c - Add "char *rootFileName" as the argument to Use_MATLAB src/gdata.h - Add "char* rootFileName" as the argument to Generate function prototype src/gen.c - Add "char* rootFileName" as the argument to Generate Signed-off-by: Bob Yantosca <[email protected]>
yantosca
added
build
jimmielin
approved these changes
Jun 13, 2024
Member
jimmielin
left a comment
jimmielin
left a comment
There was a problem hiding this comment.
Looks good to me. These updates the function prototypes to match the actual arguments called in src/gen.c.
Contributor
|
Thanks for the fix, @yantosca! To be honest, I don't really understand why this has worked so far. In |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the companion PR to #102. We have updated the function prototypes for the following functions to avoid compiler warnings: