Conversation
yantosca
added
mechanisms
RolfSander
approved these changes
Apr 30, 2024
Contributor
RolfSander
left a comment
RolfSander
left a comment
There was a problem hiding this comment.
The new limits in the feature/mcm branch work fine for me, and I think we're ready to merge. Unless, of course, you run into problems on some other machines with the higher limits.
Contributor
Author
|
Thanks @RolfSander. The code builds & runs even on my PC (Windows Subsystem for Linux) so I think it should be OK. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR seeks to merge a couple of outstanding commits in the
feature/mcmbranch into dev. Namely to increase the size of arrays needed to use the full MCM and also to add the-recursiveflag to gfortran.