Skip to content

$KPP_ROOT_Fun( ) and $KPP_ROOT_Fun_Chem( ) bug still in KPP v3.1.0 for matlab code #96

@jnavarla

Description

@jnavarla

Hi every one,
Nice improvements in the v3.1.0 for debbuging *.spc and *.eqn files.

But, the problem on the generation of the matlab code from version 3.0 still is not corrected.
The generated $KKP_ROOT_Fun.m file defines the function as:
function [ Aout ] = $KPP_ROOT_Fun ( V , F , RCT , Vdot )
while the function is called in %KKP_ROOT_Fun_Chem.m as:
P = $KPP_ROOT_Fun( Y, FIX, RCONST );
Then the matlab function is obiously bad defined.

I would suggest to define the Fun.m function as:
function [ Vdot, Aout ] = $KKP_ROOT_Fun ( V , F , RCT )
Defined in this way the function could be called in Fun_Chem.m as:
[P, ~]= $KPP_ROOT_Fun( Y, FIX, RCONST );
and the same function could be useful for the calculation of all the reaction rates after the integration of the model as:
[~, RR]= $KPP_ROOT_Fun( Y, FIX, RCONST );

I recognize that this is the previous #56 Issue where apparently there is proposed a solution but still is not implemented.
Best regards,
Javier

Metadata

Metadata

Assignees

Labels

bugSomething isn't workingtarget-languagesRelated to the language options for KPP-generated code

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions