Provide time in ISO format #1263
Conversation
chrarnoldus
requested review from
Copilot,
hassoncs,
kevinvandijk and
markijbema
🦋 Changeset detectedLatest commit: 402d32d The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
Adds ISO 8601 formatting for the current time and simplifies the timezone lookup.
- Replaces custom date formatting and offset calculation with
toISOString()for UTC output - Retains user time zone name via
Intl.DateTimeFormat().resolvedOptions().timeZone - Marks changes with
kilocode_changecomments
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| src/core/environment/getEnvironmentDetails.ts | Switch to ISO UTC format and remove verbose formatter |
| .changeset/clever-lights-sleep.md | Notes that time is now provided in ISO format |
Comments suppressed due to low confidence (1)
src/core/environment/getEnvironmentDetails.ts:186
- Consider adding or updating unit tests to verify that the output includes the ISO string and the user time zone as expected, ensuring this change is covered for future regressions.
details += `\n\n# Current Time\nCurrent time in ISO 8601 UTC format: ${now.toISOString()}\nUser time zone: ${timeZone}`
|
I tried a bunch of models and they all seem to get it. They might ramble about the time zone conversion though. |
|
Should add the offset back |
|
Some funny stuff from Opus before this change:
|
No description provided.